Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on race detector for all go tests #2856

Merged
merged 2 commits into from
Jul 14, 2017
Merged

Turn on race detector for all go tests #2856

merged 2 commits into from
Jul 14, 2017

Conversation

helinwang
Copy link
Contributor

No description provided.

@helinwang helinwang changed the title turn on race detector for all go tests Turn on race detector for all go tests Jul 13, 2017
typhoonzero
typhoonzero approved these changes Jul 14, 2017
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

dzhwinter
dzhwinter approved these changes Jul 14, 2017
View reviewed changes
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@helinwang helinwang merged commit 5812302 into PaddlePaddle:develop Jul 14, 2017
@helinwang helinwang deleted the race branch July 14, 2017 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzhwinter dzhwinter dzhwinter approved these changes

@typhoonzero typhoonzero typhoonzero approved these changes

@gangliao gangliao Awaiting requested review from gangliao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@helinwang @dzhwinter @typhoonzero