Fix memory deps on device context #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gangliao
reviewed
Jul 23, 2017
| @@ -1,14 +1,16 @@ | |||
| add_subdirectory(detail) | |||
|
|
|||
| cc_library(memory SRCS memory.cc) | |||
| cc_library(memcpy SRCS memcpy.cc) | |||
| cc_library(memcpy SRCS memcpy.cc DEPS device_context) | |||
There was a problem hiding this comment.
I don't think GPUPlaceGuard and CPUPlaceGuard are necessary here. We don't need to roll back the previous device id after usage. Because we still need to set device id when we want to use it. The explicitly set device id is a good option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3020