Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update gradient operator registry mechanism #3036

Merged
merged 4 commits into from
Jul 25, 2017
Merged

update gradient operator registry mechanism #3036

merged 4 commits into from
Jul 25, 2017

Conversation

JiayiFeng
Copy link
Collaborator

@JiayiFeng JiayiFeng commented Jul 24, 2017 •
edited

OLD:
op_type --> grad_op_creator

NEW:
grad_op_type --> grad_op_creator
op_type --> grad_op_type

This change makes it possible to register grad op's grad op.

@JiayiFeng
Change gradient Op registry mechanism
77af58f 
OLD: op_type -> grad_op_creator

NEW: grad_op_type -> grad_op_creator
     op_type -> grad_op_type
@JiayiFeng
Rewrite grad_op registry macro of mul, sigmoid and softmax
197c82f
@JiayiFeng
fix compile error
ae6009d
dzhwinter
dzhwinter reviewed Jul 25, 2017
View reviewed changes
paddle/framework/op_registry.h
}

private:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why make op_creators public? In my mind, it is only used by the CreatorOp and RegisterOp.

Copy link
Collaborator Author

@JiayiFeng JiayiFeng Jul 25, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also used by GradOpBuilder. Because all gradient operators are also registered in op_creators.

dzhwinter
dzhwinter approved these changes Jul 25, 2017
View reviewed changes
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiayiFeng JiayiFeng merged commit 72b5bd9 into PaddlePaddle:develop Jul 25, 2017
@JiayiFeng JiayiFeng deleted the dev_update_backward branch July 25, 2017 03:37
heavengate pushed a commit to heavengate/Paddle that referenced this pull request Aug 16, 2021
@wangxinxin08
reduce worker_num of ppyolov2 (PaddlePaddle#3036)
f29d636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzhwinter dzhwinter dzhwinter approved these changes

@reyoung reyoung Awaiting requested review from reyoung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JiayiFeng @dzhwinter