Enforce add more helpers #3233
Merged
Enforce add more helpers #3233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gangliao
reviewed
Aug 4, 2017
paddle/platform/enforce.h
Outdated
| @@ -162,5 +162,11 @@ inline void throw_on_error(T e) { | |||
| } \ | |||
| } while (0) | |||
|
|
|||
| #define PADDLE_ENFORCE_EQ(__VAL0, __VAL1, ...) \ | |||
There was a problem hiding this comment.
is this kind of macros EQ, NE, NOTNULL necessary?
There was a problem hiding this comment.
discussed with @Superjom, it's important to use PADDLE_ENFORCE_EQ to print the mismatch value for users to debug if the error exists.
gangliao
reviewed
Aug 4, 2017
paddle/platform/enforce.h
Outdated
| @@ -162,5 +162,11 @@ inline void throw_on_error(T e) { | |||
| } \ | |||
| } while (0) | |||
|
|
|||
| #define PADDLE_ENFORCE_EQ(__VAL0, __VAL1, ...) \ | |||
| PADDLE_ENFORCE((__VAL0) == (__VAL1), \ | |||
There was a problem hiding this comment.
@Superjom like Glog, there is a bug might trigger a compilation warning/error.
we might need to fix it.
template<typename T1, typename T2>
struct min_type {
static const bool t1_to_t2 = std::is_convertible<T1, T2>::value;
typedef typename std::conditional<t1_to_t2, T2, T1>::type type;
};
typedef typename min_type<decltype(__VAL0), decltype(__VAL1)>::type T;
PADDLE_ENFORCE(T(__VAL0) == T(__VAL1), ...
gangliao
approved these changes
Aug 4, 2017
heavengate
pushed a commit
to heavengate/Paddle
that referenced
this pull request
Aug 16, 2021
* update mot doc config, test=document_fix * update citations, test=document_fix * update title, test=document_fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3229
Will wait for more reviewing suggestions before add other enforces.
reference
https://caffe2.ai/doxygen-c/html/logging_8h_source.html
same usages.