support python39 and delete python35 in Dockerfile #32385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
| @@ -20,36 +20,36 @@ REPO="${REPO:-paddledocker}" | |||
|
|
|||
| function make_cuda9cudnn7(){ | |||
| sed 's/<baseimg>/9.0-cudnn7-devel-centos7/g' Dockerfile.centos >Dockerfile.tmp | |||
| sed -i "s#RUN bash build_scripts/build.sh#RUN bash build_scripts/install_gcc.sh gcc54 \nRUN mv /usr/bin/cc /usr/bin/cc.bak \&\& ln -s /usr/local/gcc-5.4/bin/gcc /usr/bin/cc \nENV PATH=/usr/local/gcc-5.4/bin:\$PATH \nRUN bash build_scripts/build.sh#g" Dockerfile.tmp | |||
| sed -i "s#RUN bash build_scripts/build.sh#RUN bash build_scripts/install_gcc.sh gcc54 \nRUN mv /usr/bin/gcc /usr/bin/gcc.bak \&\& ln -s /usr/local/gcc-5.4/bin/gcc /usr/bin/gcc \nENV PATH=/usr/local/gcc-5.4/bin:\$PATH \nRUN bash build_scripts/build.sh#g" Dockerfile.tmp | |||
There was a problem hiding this comment.
问题：
QA说manylinux镜像里，使用/usr/bin/gcc -v得到的gcc版本是gcc4.8（gcc -v是正确的gcc8.2版本）。
这里的解决方法：
在manylinux镜像里尝试ln -s /usr/local/gcc-5.4/bin/gcc /usr/bin/gcc后，/usr/bin/gcc -v得到的版本变成了gcc8.2。
仍然出现的问题：
在已经生成好的镜像里测试没问题，但是修改后重新生成镜像/usr/bin/gcc -v仍然是gcc4.8。感觉是修改gcc版本后续的某个步骤里，重新装了gcc4.8。
结论：
这个问题还没修复，不过对发包没影响，准备之后找时间修。这个改动也不影响正常功能，看能否先合入这个PR，后续再处理这个问题？
|
QA测试不影响发包，可以先合入，之后再修问题 |
tianshuo78520a
approved these changes
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
/usr/bin/gcc -v版本不对的问题，但是这个PR里的修改没有效果。这个问题对发包没影响，之后再修。