Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use boost::any other than linb::any #3284

Closed
wants to merge 2 commits into from

Conversation

wangkuiyi
Copy link
Collaborator

In hope to fix #3283, but not sure if it works.

@wangkuiyi
Copy link
Collaborator Author

I filed two experiments to fix this problem --

  1. PR Use boost::any other than linb::any #3284 switches from thelink2012/any to boost::any, and
  2. PR Use PaddlePaddle fork of any #3286 switches to a PaddlePaddle's fork of any with the noexcept bug fixed.

Because thelink2012/any doesn't have versioning tags nor two-branch Git branching model, it seems pretty hacky and less maintained project, I'd prefer to merge PR #3284 if it passes CI and suppress the noexcept warning.

@wangkuiyi
Copy link
Collaborator Author

wangkuiyi commented Aug 6, 2017

Curious -- TeamCity CI passed, but Android-build on Travis CI failed. Could @Xreki @hedaoyuan please have a look at this?

Is this because our Android-CI is not running in Docker container and the CI doesn't install boost? I remember that our CMake script doesn't download boost and it relies on pre-installed boost.

@Xreki
Copy link
Contributor

Xreki commented Aug 7, 2017

@wangkuiyi We use Google's NDK to build PaddlePaddle for Android devices. It does not include a pre-build boost and we have never built boost for Android manually since the dependency of boost is possible to be removed. To access boost for Android, we may need more work. If it is indispensable, I'll fix it.

@wangkuiyi
Copy link
Collaborator Author

Close this PR because we need to do something to allow our Android-build to use boost.

@wangkuiyi wangkuiyi closed this Aug 7, 2017
heavengate pushed a commit to heavengate/Paddle that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

168 warnings from any
2 participants