Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix C-API Compilation Error #3311

Merged
merged 3 commits into from
Aug 8, 2017
Merged

Fix C-API Compilation Error #3311

merged 3 commits into from
Aug 8, 2017

Conversation

gongweibao
Copy link
Contributor

@gongweibao gongweibao commented Aug 7, 2017 •
edited

FIX #3329

@gongweibao gongweibao requested review from wangkuiyi, reyoung, typhoonzero and gangliao and removed request for wangkuiyi August 7, 2017 13:36
typhoonzero
typhoonzero reviewed Aug 7, 2017
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Need an issue to describe the problem.
  • Curious why adding this if can fix since the default is ON.

paddle/framework/CMakeLists.txt Outdated
@@ -44,3 +46,4 @@ cc_library(paddle_pybind SHARED
mean_op
cross_entropy_op
recurrent_op)
endif()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endif() => endif(WITH_PYTHON)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

paddle/framework/CMakeLists.txt Outdated
@@ -35,6 +35,8 @@ add_dependencies(framework_py_proto framework_py_proto_init)

cc_library(backward SRCS backward.cc DEPS net_op)
cc_test(backward_test SRCS backward_test.cc DEPS backward)

if (WITH_PYTHON)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No space after if in cmake

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@wangkuiyi
Copy link
Collaborator

Fixcapi ==> Fix C-API Compilation Error

@wangkuiyi
Copy link
Collaborator

Also, we need a Github issue describing the problem and the ideal to fix it. A good example is @luotao1 's work #3310

@gongweibao gongweibao changed the title Fixcapi Fix C-API Compilation Error Aug 8, 2017
@gongweibao
Copy link
Contributor Author

Thanks all!

wangkuiyi
wangkuiyi approved these changes Aug 8, 2017
View reviewed changes
Copy link
Collaborator

@wangkuiyi wangkuiyi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks to @gongweibao for fixing this!

@gongweibao gongweibao merged commit 8c2a0a7 into PaddlePaddle:develop Aug 8, 2017
@gongweibao gongweibao deleted the fixcapi branch August 8, 2017 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typhoonzero typhoonzero typhoonzero left review comments

@wangkuiyi wangkuiyi wangkuiyi approved these changes

@reyoung reyoung Awaiting requested review from reyoung

@gangliao gangliao Awaiting requested review from gangliao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gongweibao @wangkuiyi @typhoonzero