Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"mul op gradient" #3379

Merged
merged 15 commits into from
Aug 18, 2017
Merged

"mul op gradient" #3379

merged 15 commits into from
Aug 18, 2017

Conversation

dzhwinter
Copy link
Contributor

@dzhwinter dzhwinter commented Aug 10, 2017

fix #3370
implement mul op gradient need the transpose feature of EigenTensor. But it does not support well in the current stage. So, this PR depends on @QiJune 's wrapper on Blas library.

@jacquesqiao jacquesqiao mentioned this pull request Aug 18, 2017
@jacquesqiao
Copy link
Member

math matmul has some problem, I am fixing it. #3577

@dzhwinter
Copy link
Contributor Author

there is a bug in the math library. further more, the mul grad op gradient has a enlarge effect on max_relative_error. This PR fix #3577 #3579

Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@dzhwinter dzhwinter merged commit ac66335 into PaddlePaddle:develop Aug 18, 2017
@jacquesqiao jacquesqiao mentioned this pull request Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MulOp backward implenmentation.
2 participants