Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix decoding error when clip grad op. #33919

Merged
merged 1 commit into from Jul 2, 2021

Conversation

jiweibo
Copy link
Contributor

@jiweibo jiweibo commented Jul 1, 2021

PR types

Others

PR changes

Others

Describe

Fix decoding error when clip grad op and kernel.

部分代码注释中存在全角、中文标点等符号,裁剪脚本不加encoding会挂掉。

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 1, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jiweibo jiweibo requested a review from OliverLPH July 2, 2021 04:40
Copy link
Contributor

@DannyIsFunny DannyIsFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiweibo jiweibo merged commit d5bdfaf into PaddlePaddle:develop Jul 2, 2021
@jiweibo jiweibo deleted the fix_clip_grad branch July 2, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants