[hybird optim] reduce rend/recv times for recompute #34248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
| 'out_shape': var_shape, | ||
| 'dtype': var.dtype, | ||
| self._op_device_key: cur_dev, | ||
| self._op_role_key: op_role, |
There was a problem hiding this comment.
之后加一个断言，recompute这个情况下op_role为backward
| @@ -4867,15 +4900,13 @@ def _insert_send_recv(cur_id, prev_id): | |||
| }) | |||
| extra_index_info['index'] += 1 | |||
| insert_index = None | |||
|
|
|||
| @@ -17,6 +17,7 @@ list(APPEND DIST_TEST_OPS test_parallel_dygraph_sparse_embedding) | |||
| list(APPEND DIST_TEST_OPS test_parallel_dygraph_sparse_embedding_over_height) | |||
| list(APPEND DIST_TEST_OPS test_parallel_dygraph_transformer) | |||
| list(APPEND DIST_TEST_OPS test_fleet_pipeline_meta_optimizer) | |||
| list(APPEND DIST_TEST_OPS test_fleet_pipeline_meta_optimizer_with_recompute) | |||
There was a problem hiding this comment.
单测加到原来test_fleet_pipeline_meta_optimizer会出错吗
FeixLiu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
Others
Describe
观察到recompute的var在forward pass与recompute pass中均被send，会造成stage0 Backward --send--> stage1 Forward(recompute) 的情况。 优化过后，只需在前向时一次send，反向时将前向的var值assgin给 recompute的var即可。