Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build documentation don't need install Paddle before #3488

Merged
merged 2 commits into from
Aug 15, 2017
Merged

build documentation don't need install Paddle before #3488

merged 2 commits into from
Aug 15, 2017

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Aug 15, 2017

As building documentation don't need to install Paddle before (#3310 merged), refine the paddle/scripts/docker/build.sh

Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add print some information at the end of the build like "If you need to install paddle in develop docker image, please run xxx"

@luotao1
Copy link
Contributor Author

luotao1 commented Aug 15, 2017

@typhoonzero Done.

Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@luotao1 luotao1 merged commit d605560 into PaddlePaddle:develop Aug 15, 2017
@luotao1 luotao1 deleted the docker_doc branch August 15, 2017 06:01
heavengate pushed a commit to heavengate/Paddle that referenced this pull request Aug 16, 2021
* fix warning when result is empty

* fix warning when result is empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants