Refactor dropout cuda impl for code reuse. #35621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
建议 Describe 里第 (2) 条描述稍微的详细一点。 |
|
LGTM |
Done. |
| *(reinterpret_cast<LoadT*>(&dst[i])) = | ||
| *reinterpret_cast<LoadT*>(&dest_vec[0]); | ||
| *(reinterpret_cast<MaskLoadT*>(&mask_data[i])) = | ||
| *reinterpret_cast<MaskLoadT*>(&mask_vec[0]); |
There was a problem hiding this comment.
这里在当前的devleop已经不是这样写了。注意下挪动后，不要修改了内容
zhangting2020
approved these changes
Sep 13, 2021
… refactor-dropout-cuda-impl
This was referenced Sep 23, 2021
niuliling123
pushed a commit
to niuliling123/Paddle
that referenced
this pull request
Sep 29, 2021
This was referenced Oct 18, 2021
This was referenced Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
OPs
Describe
Refactor dropout cuda impl for code reuse:
(1) Move dropout cuda forward impl in dropout_op.cu and backward impl in dropout_op.h to newly dropout_impl.cu.h;
(2) Originally, the backward impl for cpu and gpu share same code. To be more clear, they are separated into two pieces.
I extract the cuda backward impl from dropout_op.h and put them in dropout_impl.cu.h.
Now, all the cpu impl is in dropout_op.h and all the gpu impl is in dropout_impl.cu.h.
Unittest Results for dropout op:
