Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Net::AddOp to Net::AppendOp #3585

Merged
merged 1 commit into from
Aug 22, 2017
Merged

Rename Net::AddOp to Net::AppendOp #3585

merged 1 commit into from
Aug 22, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Aug 20, 2017

Fix #3582

@wangkuiyi
Copy link
Collaborator

It looks to me that NetOp::AddOp is fine.

@reyoung
Copy link
Collaborator Author

reyoung commented Aug 21, 2017

@wangkuiyi

AddOp很容易与 加法Op和添加Op混淆。容易混淆的名字不应该作为我们基础类型的API出现。

@reyoung reyoung requested a review from wangkuiyi August 21, 2017 03:54
@wangkuiyi
Copy link
Collaborator

wangkuiyi commented Aug 21, 2017 •
edited

The name Append implies that the container has a linear data structure. I think it is right because a Block is just a sequence of instructions and is a linear container of operations. So I support this rename.

@reyoung reyoung merged commit ce723af into PaddlePaddle:develop Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangkuiyi wangkuiyi wangkuiyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename AddOp to AppendOp in NetOp
2 participants
@reyoung @wangkuiyi