remove input dim check in op_teller and update ut #37097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
baoachun
changed the title
jiweibo
reviewed
Nov 11, 2021
| @@ -176,12 +176,6 @@ bool OpTeller::Tell(const framework::ir::Node* node, bool use_no_calib_int8, | |||
| << " op does not support input's dim is 1 in tensorrt."; | |||
| return false; | |||
| } | |||
| // TODO(inference): fix | |||
| if (x_shape.size() == 2 && !with_dynamic_shape) { | |||
There was a problem hiding this comment.
针对二维输入的情况是如何修复的呢？pr已经合入了吗？
baoachun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
移除op_teller中一些op对2维输入的过滤，该问题已经被修复了，过滤会影响业务模型推理性能。
同时更新单测。