Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new-exec] Refine standalone executor #37278

Merged
merged 5 commits into from
Nov 17, 2021

Conversation

zhiqiu
Copy link
Contributor

@zhiqiu zhiqiu commented Nov 17, 2021

PR types

Others

PR changes

Others

Describe

Refine standalone executor

  • add feed ops in python sides to be consistent with old executor and support more feed type

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhiqiu zhiqiu changed the title Dev/fix standalone executor [new-exec] Refine standalone executor Nov 17, 2021
Aurelius84
Aurelius84 previously approved these changes Nov 17, 2021
fetch_list(list): This parameter represents the Tensors that need to be returned
after the model runs. The default is None.
return_numpy(bool): This parameter indicates whether convert the fetched Tensors
(the Tensor specified in the fetch list) to numpy.ndarray. if it is False,
the type of the return value is a list of :code:`LoDTensor`. The default is True.
"""
feed = self._update_feed(feed)
# feed = self._update_feed(feed)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释的代码后续可以考虑remove掉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thx

wanghuancoder
wanghuancoder previously approved these changes Nov 17, 2021
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu zhiqiu dismissed stale reviews from wanghuancoder and Aurelius84 via 6e0241f November 17, 2021 06:41
Copy link
Contributor

@pangyoki pangyoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu zhiqiu merged commit 6d6642c into PaddlePaddle:develop Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants