Add New API nn.HingeEmbeddingLoss #37540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
|
zhiboniu
reviewed
Nov 25, 2021
python/paddle/fluid/tests/unittests/test_hinge_embedding_loss.py
Outdated
Show resolved
Hide resolved
python/paddle/fluid/tests/unittests/test_hinge_embedding_loss.py
Outdated
Show resolved
Hide resolved
zhiboniu
reviewed
Nov 25, 2021
zhiboniu
reviewed
Nov 25, 2021
Ligoml
reviewed
Nov 26, 2021
Ligoml
reviewed
Nov 26, 2021
Ligoml
reviewed
Nov 26, 2021
zhiboniu
reviewed
Dec 7, 2021
| # get wrong label elem not in {1., -1.} | ||
| self.wrong_label = paddle.randint(-3, 3, shape=self.shape) | ||
|
|
||
| def run_dynamic_check(self): |
python/paddle/nn/functional/loss.py
Outdated
| 'hinge_embedding_loss') | ||
|
|
||
| loss = paddle.where(label == 1., input, paddle.to_tensor(0.)) + \ | ||
| paddle.where(label == -1., delta - input, paddle.to_tensor(0.)) |
There was a problem hiding this comment.
是的，粗心了，已修改。
Done, thanks.
python/paddle/nn/functional/loss.py
Outdated
| the shape is [N, \*], N is batch size and `\*` means any number of additional dimensions, available dtype is float32, float64. | ||
| label (Tensor): Label tensor containing 1 or -1, the data type is float32 or float64. | ||
| The shape of label is the same as the shape of input. | ||
| delta (float, optional): Specifies the hyperparameter delta to be used. |
There was a problem hiding this comment.
确认下，这个参数名称用delta而不用margin的原因是什么？
在margin_ranking_loss这个api里是用margin
There was a problem hiding this comment.
因为公式里用 Δ 所以我就取名为 delta。PyTorch 的同一个 API 也是用 margin，我要改成 margin 吗？
There was a problem hiding this comment.
辛苦改成margin吧，可以跟margin_ranking_loss保持一致
S-HuaBomb
dismissed stale reviews from jeff41404, TCChenlong, zhiboniu, and Ligoml
via
0391ff7
Ligoml
approved these changes
Dec 15, 2021
Caozhou1995
pushed a commit
to Caozhou1995/Paddle
that referenced
this pull request
Dec 29, 2021
* add hinge_embedding_loss * fix test_API * test_API succeed * add English doc * fixed using of expired fluid api * fix doc * fix doc and rm python/paddle/fluid/layers/loss.py * get raw python/paddle/fluid/layers/loss.py back * fix Examples bug in English doc * unique -> flatten * fix api code * fix English doc * fix functional loss English doc * fix Example doc * .numpy() -> paddle.unique() * fix unique * fix label_item_set * modified judgment equation * Got a beautiful loss equation * use paddle.to_tensor * fix loss and add static check * fix loss and add static check * delta -> margin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
Add HingeEmbeddingLoss, refer to torch.nn.HingeEmbeddingLoss