fix download mklml error #3761
Merged
fix download mklml error #3761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tensor-tang
reviewed
Aug 31, 2017
cmake/external/mklml.cmake
Outdated
| @@ -54,7 +54,8 @@ ExternalProject_Add( | |||
| ${EXTERNAL_PROJECT_LOG_ARGS} | |||
| PREFIX ${MKLML_SOURCE_DIR} | |||
| DOWNLOAD_DIR ${MKLML_DOWNLOAD_DIR} | |||
| DOWNLOAD_COMMAND wget --no-check-certificate -qO- ${MKLML_URL} | tar xz -C ${MKLML_DOWNLOAD_DIR} | |||
| DOWNLOAD_COMMAND wget --no-check-certificate ${MKLML_URL} -c -O ${MKLML_VER}.tgz | |||
There was a problem hiding this comment.
我觉得，-q还是有必要加上的，因为整体上其他Third Party一般都是后台下载，其实也不需要用户知晓。
|
LGTM 另外备注下： |
tensor-tang
approved these changes
Aug 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3758
related d777ac5