Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new API inner&outer #37706

Merged
merged 1 commit into from Dec 24, 2021
Merged

Add new API inner&outer #37706

merged 1 commit into from Dec 24, 2021

Conversation

zhiboniu
Copy link
Contributor

PR types

New features

PR changes

APIs

Describe

Add new API inner&outer

paddle.inner Examples:

            import paddle
            x = paddle.arange(1, 7).reshape((2, 3)).astype('float32')
            y = paddle.arange(1, 10).reshape((3, 3)).astype('float32')
            out = paddle.inner(x, y)
            print(out)
            #        ([[14, 32, 50],
            #         [32, 77, 122]])

paddle.outer Examples:

            import paddle
            x = paddle.arange(1, 4).astype('float32')
            y = paddle.arange(1, 6).astype('float32')
            out = paddle.outer(x, y)
            print(out)
            #        ([[1, 2, 3, 4, 5],
            #         [2, 4, 6, 8, 10],
            #         [3, 6, 9, 12, 15]])

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

jeff41404
jeff41404 reviewed Dec 2, 2021
View reviewed changes
python/paddle/tensor/math.py
var_names = {'x': x, 'y': y}
for name, val in var_names.items():
check_variable_and_dtype(val, name,
['float16', 'float32', 'float64'], 'inner')
Copy link
Contributor

@jeff41404 jeff41404 Dec 2, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we support data type of complexfloat64 and complexfloat128 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

复数后面再支持

jeff41404
jeff41404 reviewed Dec 2, 2021
View reviewed changes
python/paddle/tensor/math.py
var_names = {'x': x, 'y': y}
for name, val in var_names.items():
check_variable_and_dtype(val, name,
['float16', 'float32', 'float64'], 'inner')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we support data type of complexfloat64 and complexfloat128 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

复数后面再支持

@paddle-bot-old
Copy link

paddle-bot-old bot commented Dec 9, 2021

Sorry to inform you that 78191ad's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

phlrain
phlrain previously approved these changes Dec 16, 2021
View reviewed changes
@phlrain phlrain self-requested a review December 20, 2021 13:28
phlrain
phlrain previously approved these changes Dec 20, 2021
View reviewed changes
jeff41404
jeff41404 previously approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 previously approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jzhang533
jzhang533 reviewed Dec 22, 2021
View reviewed changes
python/paddle/tensor/math.py Outdated
Outer product of two Tensors.

Args:
x (Tensor): The input tensor which is a Tensor.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个描述，更新一下吧。

python/paddle/tensor/math.py Outdated
user to set this property. For more information, please refer to :ref:`api_guide_Name`

Returns:
Tensor: The inner product Tensor.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

写错了。

jzhang533
jzhang533 previously approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

XiaoguangHu01
XiaoguangHu01 previously approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 approved these changes Dec 24, 2021
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TCChenlong
TCChenlong approved these changes Dec 24, 2021
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeff41404 jeff41404 merged commit b463dff into PaddlePaddle:develop Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TCChenlong TCChenlong TCChenlong approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@jzhang533 jzhang533 jzhang533 left review comments

@jeff41404 jeff41404 jeff41404 left review comments

@phlrain phlrain phlrain left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zhiboniu @jzhang533 @jeff41404 @TCChenlong @phlrain @XiaoguangHu01