Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Amax and Amin API #38417

Merged
merged 2 commits into from
Dec 28, 2021
Merged

Add Amax and Amin API #38417

merged 2 commits into from
Dec 28, 2021

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Dec 24, 2021 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

@paddle-bot-old
Copy link

paddle-bot-old bot commented Dec 24, 2021 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@luotao1 luotao1 changed the title [DO NOT merge]Amax and Amin Add Amax and Amin API Dec 27, 2021
jeff41404
jeff41404 approved these changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XieYunshen
XieYunshen reviewed Dec 28, 2021
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
UT重命名：test_max_min_op -> test_max_min_amax_amin_op

TCChenlong
TCChenlong approved these changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO：Add max/min backward

zhiqiu
zhiqiu approved these changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 340dfb2 into PaddlePaddle:develop Dec 28, 2021
@luotao1 luotao1 deleted the amax branch December 28, 2021 06:49
This was referenced Dec 28, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XieYunshen XieYunshen XieYunshen left review comments

@zhiqiu zhiqiu zhiqiu approved these changes

@jeff41404 jeff41404 jeff41404 approved these changes

@TCChenlong TCChenlong TCChenlong approved these changes

@lanxianghit lanxianghit lanxianghit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@luotao1 @zhiqiu @jeff41404 @TCChenlong @XieYunshen @lanxianghit