Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pten] Replace platform::Place to pten::Place. #38899

Merged
merged 28 commits into from
Jan 17, 2022
Merged

[Pten] Replace platform::Place to pten::Place. #38899

merged 28 commits into from
Jan 17, 2022

Conversation

jiweibo
Copy link
Contributor

@jiweibo jiweibo commented Jan 12, 2022 •
edited
Loading

PR types

Others

PR changes

Others

Describe

Replace platform::Place to pten::Place.

  1. remove all BOOST_GET_CONST for place.
  2. boost::apply_visitor -> paddle::platform::VisitPlace.
  3. memory::Copy support pten::Place.
  4. place.which() -> place.GetType()
  5. remove all forward declaration struct CPUPlace;.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jiweibo jiweibo mentioned this pull request Jan 16, 2022
Merged
Aurelius84
Aurelius84 approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhiqiu
zhiqiu approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Avin0323
Avin0323 approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@Avin0323 Avin0323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for PR-CI-OP-Benchmark

@jiweibo jiweibo merged commit c48a9ad into PaddlePaddle:develop Jan 17, 2022
@jiweibo jiweibo deleted the place_for_all branch January 17, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@chenwhql chenwhql chenwhql approved these changes

@zhiqiu zhiqiu zhiqiu approved these changes

@TCChenlong TCChenlong TCChenlong approved these changes

@Avin0323 Avin0323 Avin0323 approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@raindrops2sea raindrops2sea raindrops2sea approved these changes

@Shixiaowei02 Shixiaowei02 Shixiaowei02 approved these changes

@XiaoguangHu01 XiaoguangHu01 Awaiting requested review from XiaoguangHu01 XiaoguangHu01 is a code owner

@phlrain phlrain Awaiting requested review from phlrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@jiweibo @zhiqiu @Aurelius84 @TCChenlong @chenwhql @Avin0323 @YuanRisheng @raindrops2sea @Shixiaowei02