[Move selected_rows PR #2] Added Selected_Rows and rw_lock to Pten #39087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
… fluid_move_selected_rows_to_pten_2
veyron95
force-pushed
the
fluid_move_selected_rows_to_pten_2
branch
from
b1f9f8d
to
9668819
Compare
… fluid_move_selected_rows_to_pten_2
… fluid_move_selected_rows_to_pten_2
YuanRisheng
previously approved these changes
Jan 22, 2022
YuanRisheng
previously approved these changes
Jan 22, 2022
chenwhql
reviewed
Jan 22, 2022
chenwhql
approved these changes
Jan 22, 2022
XieYunshen
approved these changes
Jan 22, 2022
This was referenced Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
A series of jobs where selected_rows moves from Fluid to Pten.
There are 5 PR to complete the migration work in expected.
PR 1: Renamed selected_rows.* to selected_rows_utils.* PR39037
This is PR 2: Added selected_rows.* and rw_lock.h to Pten
NOTE:
"paddle/fluid/framework/mixed_vector.h" will be removed soon by @Aurelius84（留杰）.
"paddle/fluid/framework/data_type.h" will be removed in PR4.
follow-up work：
PR 3: Change the relationship of [include/Cmake].
PR 4: VisitDataType -> Pten::DataType.
PR 5: SelectedRows inherits from TensorBase.