[Refactoring Tensor PR #7] differentiate deprecated interfaces #39228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Shixiaowei02
force-pushed
the
dev/tensor_include
branch
2 times, most recently
from
da23fb0
to
63371a7
Compare
Shixiaowei02
force-pushed
the
dev/tensor_include
branch
from
7103f41
to
7328b7c
Compare
Shixiaowei02
changed the title
Shixiaowei02
changed the title
jim19930609
approved these changes
Jan 26, 2022
chenwhql
reviewed
Jan 26, 2022
| inline bool IsInitialized() const { return holder_ != nullptr; } | ||
|
|
||
| template <typename T> | ||
| T* data(); |
There was a problem hiding this comment.
data也不需要吗？还是说要加mutable_data了
There was a problem hiding this comment.
我建议留 data() 接口，下个相关的PR中我移回来，并且补全注释
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
APIs
Describe
目前
DenseTensor处于一个中间态。使用单独的源文件存放待清理的接口（如依赖其它第三方库的），以便其它上层框架依赖。达到最终态后，这个单独的文件将重新合并。