-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactorization overview #3970
Refactorization overview #3970
Conversation
1. create operators and set attributes, | ||
1. validate attribute values, | ||
1. inference the type and the shape of variables, | ||
1. plan for memory-reuse for variables, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the order should be
1. generate backward and optimization part of the Graph
1. plan for memory-reuse for variables
memory-reuse should be done after the graph is completed.
- when graph executes, a Block with `BlockDesc` passed in creates `Op` and `Var` then `Run` | ||
|
||
--- | ||
# Milestone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Milestone
should be in another pr or issue because other parts of this PR is a summary of the refactorized Paddle. They are knowledge but not plan.
|
||
1. Users write Python programs to describe the graphs and run it (locally or remotely). | ||
|
||
1. A graph is composed of *variabels* and *operators*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variabels => variables
- accept imperfection, concentrated on solving the specific problem at the right price. | ||
|
||
--- | ||
# Control the migration quality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Milestone* and Control the migration quality is not part of refactorization overview structure, it's better to move them into the roadmap or sth like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very good material to have an overview of PaddlePaddle refactor, we can merge it first and then optimize later.
No description provided.