[phi] move unbind to phi #39789
Merged
[phi] move unbind to phi #39789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhiqiu
force-pushed
the
unbind_to_phi
branch
from
920027f
to
6a9cbc1
Compare
zhiqiu
force-pushed
the
unbind_to_phi
branch
from
6a9cbc1
to
4b8f9c0
Compare
chenwhql
reviewed
Feb 22, 2022
paddle/phi/kernels/unbind_kernel.cc
Outdated
| #include "paddle/fluid/operators/detail/strided_memcpy.h" | ||
| #include "paddle/phi/backends/all_context.h" | ||
| #include "paddle/phi/core/kernel_registry.h" | ||
| #include "paddle/phi/kernels/cpu/concat_and_split.h" |
There was a problem hiding this comment.
这里好像不太对，为什么只需要cpu的，是不是还是得用operators/math下concat_and_split
There was a problem hiding this comment.
这里其实应该迁移过来的，cpu和gpu下面的concat_and_split应该在funcs下更好，之前迁移的不到位
paddle/phi/kernels/unbind_kernel.cc
Outdated
| #include "paddle/phi/backends/all_context.h" | ||
| #include "paddle/phi/core/kernel_registry.h" | ||
| #include "paddle/phi/kernels/cpu/concat_and_split.h" | ||
| #include "paddle/phi/kernels/flatten_kernel.h" |
paddle/phi/kernels/unbind_kernel.cc
Outdated
| namespace phi { | ||
|
|
||
| template <typename T, typename Context> | ||
| void UnbindKernel(const Context& ctx, |
There was a problem hiding this comment.
这种情况，应该属于在impl下面加cpu和gpu公共实现，然后在cpu和gpu下面分别注册的写法？kernels根目录下kernel.cc中的实现，需要是完全设备无关的
chenwhql
approved these changes
Feb 23, 2022
| #include <vector> | ||
|
|
||
| #include "paddle/fluid/framework/convert_utils.h" | ||
| #include "paddle/fluid/framework/eigen.h" |
| @@ -14,7 +14,7 @@ limitations under the License. */ | |||
|
|
|||
| #include "paddle/fluid/operators/math/concat_and_split.h" | |||
|
|
|||
| #include "paddle/phi/kernels/cpu/concat_and_split.h" | |||
| #include "paddle/phi/kernels/funcs/concat_and_split_functor.h" | |||
| #include <vector> | ||
|
|
||
| #include "paddle/fluid/framework/convert_utils.h" | ||
| #include "paddle/fluid/framework/eigen.h" |
| #include <vector> | ||
|
|
||
| #include "paddle/fluid/framework/convert_utils.h" | ||
| #include "paddle/fluid/framework/eigen.h" |
raindrops2sea
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Breaking changes
PR changes
OPs
Describe
move unbind to phi