[Candidate solution] Add an elementwise + activation fusion pass, add mechanizm to add attributes outside of base op. #40081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
| } | ||
| return post_operations; | ||
| } | ||
|
|
There was a problem hiding this comment.
Hi, I only have one question, why these getting attributes and computation function are in xx.h file? It will not increase the lib size? Thanks !
There was a problem hiding this comment.
There is no .cc file and I didn't create it.
tsocha
force-pushed
the
el_add_ect_fuse_experimental
branch
from
1a1f967
to
64a8277
Compare
lidanqing-intel
changed the title
|
This solution has been selected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Function optimization
Describe
Add a pass which fuse elementwise operation with activations and add new attributes in the pass during runtime
This is another candidate solution of PR Add an elementwise + activation fusion pass. #36541, according to Achun and Hongyu's suggestion.