Modify save_quant_model to support different input and output filenames #40542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
sfraczek
reviewed
Mar 14, 2022
| test_args.ops_to_quantize, test_args.op_ids_to_skip, test_args.debug) | ||
| test_args.ops_to_quantize, test_args.op_ids_to_skip, test_args.debug, | ||
| test_args.save_model_filename, test_args.save_params_filename, | ||
| test_args.quant_model_filename, test_args.quant_params_filename) |
There was a problem hiding this comment.
quant_xxx_filename should be first
There was a problem hiding this comment.
You are totally right. Thank you
liqitong-a
pushed a commit
to liqitong-a/Paddle
that referenced
this pull request
Mar 17, 2022
…es (PaddlePaddle#40542) * Modify save_quant_model.py to support differnet input and output filenames * Correct wrong order of arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
This PR adds additional parameters to save_quant_model.py to define the names of the input and output files. The default version of the input and output file names remains the same as before.