Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table refine: remove table/accessor unuseful #41400

Merged
merged 33 commits into from Apr 5, 2022
Merged

Table refine: remove table/accessor unuseful #41400

merged 33 commits into from Apr 5, 2022

Conversation

zhaocaibei123
Copy link
Contributor

@zhaocaibei123 zhaocaibei123 commented Apr 4, 2022 •
edited

PR types

Others

PR changes

Others

Describe

  1. remove unuseful tables： CommonSparseTable GeoSparseTable SSDSparseTable
  2. CommonDenseTable -> MemoryDenseTable
  3. remove unuseful accessor: DownpourCtrAccessor, add show_scale for CtrCommonAccessor

esythan and others added 30 commits March 30, 2022 14:12
@esythan
update name
2b967c7
@esythan
update name
61e6d9e
@esythan
fix test
f78fbb5
@esythan
fix fleet bind
c6c7ec0
@esythan
update name
fe93dca
@esythan
update name
9a943b6
@esythan
resolve conflict
257d224
@zhaocaibei123
Merge branch 'name' of https://github.com/esythan/Paddle into async_r…
e57e74d 
…efine
@esythan
fix test
9a7a2cf
@zhaocaibei123
Merge branch 'name' of https://github.com/esythan/Paddle into async_r…
0f4bf8b 
…efine
@esythan
fix gpups wrapper
8fdb7ef
@zhaocaibei123
remove Push/Pull/Load/Save with context in client and wrapper base class
16b94a5
@zhaocaibei123
Merge branch 'name' of https://github.com/esythan/Paddle into async_r…
648cf62 
…efine
@zhaocaibei123
fix conflict
80f95df
@zhaocaibei123
Merge branch 'develop' into async_refine
03b6c3b
@zhaocaibei123
fix
65c505f
@zhaocaibei123
fix
d4ea5d1
@zhaocaibei123
remove some interface
1e763e4
@zhaocaibei123
fix
40c1539
@zhaocaibei123
remove
e949912
@zhaocaibei123
fix conflict
e14295f
@zhaocaibei123
code style
1d808d3
@zhaocaibei123
recover
56c9033
@zhaocaibei123
fix
878fbc2
@zhaocaibei123
remove code unused
02bdabc
@zhaocaibei123
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
701fc28 
… table_refine2
@zhaocaibei123
remove some unused table & accessor & CommonDenseTable => MemoryDense…
65ac027 
…Table
@zhaocaibei123
fix
49c6f30
@zhaocaibei123
fix
9395987
@zhaocaibei123
fix
cb6267a
@paddle-bot-old
Copy link

paddle-bot-old bot commented Apr 4, 2022 •
edited

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Apr 4, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhaocaibei123 zhaocaibei123 changed the title Table refine3 Table refine: remove table/accessor unuseful Apr 5, 2022
XiaoguangHu01
XiaoguangHu01 approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuyinno4 fuyinno4 merged commit a288fca into PaddlePaddle:develop Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuyinno4 fuyinno4 fuyinno4 approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhaocaibei123 @fuyinno4 @XiaoguangHu01 @esythan