[Fleet Executor]Add sink interceptor and test #41497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiYuRio
changed the title
|
你的PR提交成功，感谢你对开源项目的贡献! |
wangxicoding
approved these changes
Apr 8, 2022
| void SinkInterceptor::StopCarrierIfComplete() { | ||
| bool flag = true; | ||
| for (const auto& up : upstream_step_) { | ||
| flag = flag & (up.second == max_run_times_); |
There was a problem hiding this comment.
感觉用 && 比较好一些，毕竟bool还是用字节存储的，理论上 >0 的都是true。
| std::string carrier_id = "0"; | ||
| Carrier* carrier = | ||
| GlobalMap<std::string, Carrier>::Create(carrier_id, carrier_id); | ||
| carrier->Init(0, {{-1, 0}, {0, 0}, {-2, 0}}); |
There was a problem hiding this comment.
后续把-1和-2这两个魔数搞成宏定义或者数值常量？好看点
douch
pushed a commit
to douch/Paddle
that referenced
this pull request
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
在一个进程中，只会有一个SinkInterceptor，它负责根据当前运行步数，判断是否能停止carrier。SinkInterceptor接收上游发送的DataIsReady的消息，自增计步器，直到达到最大运行上限时停止carrier。