add SymbolTable for Block #4172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquesqiao
reviewed
Sep 19, 2017
| namespace paddle { | ||
| namespace framework { | ||
|
|
||
| const OpDesc* SymbolTable::NewOp() { |
There was a problem hiding this comment.
New a Op Desc, SymbolTable is a container of compile-time instances, this op means an op in compile-time, that is a OpDesc.
jacquesqiao
reviewed
Sep 19, 2017
paddle/framework/block.cc
Outdated
| return &(it->second); | ||
| } | ||
| if (recursive) { | ||
| return parent_->FindVar(name, true); |
There was a problem hiding this comment.
should judge if parent_ is null
reyoung
reviewed
Sep 20, 2017
| private: | ||
| SymbolTable* parent_{nullptr}; | ||
| std::vector<OpDesc> ops_; | ||
| std::map<std::string, VarDesc> vars_; |
reyoung
reviewed
Sep 20, 2017
| class SymbolTable { | ||
| public: | ||
| SymbolTable() {} | ||
| explicit SymbolTable(SymbolTable* parent) : parent_(parent) {} |
There was a problem hiding this comment.
Where is deconstructor, should we disable the Copy & Assign?
|
It seems that due to the merge of #4241, this PR could be closed? @Superjom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one part of Block's Implementation according to compile period of block design.
The block's implementation will be split into several stages, this is the first one which supports block's compile, to enable InferShape's development to be done parallel.
resolves: #4171