upgrade pre-commit tools in docker #43534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
added 6 commits
June 17, 2022 10:45
|
LGTM |
pangyoki
reviewed
Jun 22, 2022
tools/dockerfile/Dockerfile.ubuntu18
Outdated
| @@ -45,8 +50,7 @@ RUN wget -q https://cmake.org/files/v3.16/cmake-3.16.0-Linux-x86_64.tar.gz && ta | |||
| ENV PATH=/home/cmake-3.16.0-Linux-x86_64/bin:$PATH | |||
|
|
|||
|
|
|||
| RUN apt-get update && \ | |||
| apt-get install -y python2.7 python2.7-dev \ | |||
| RUN apt-get install -y --fix-missing python2.7 python2.7-dev \ | |||
There was a problem hiding this comment.
这里为什么要这样改？需要把apt-get update删掉吗？
sneaxiy
pushed a commit
to sneaxiy/Paddle
that referenced
this pull request
Jun 27, 2022
* upgrade pre-commit tools in docker * python36 support pre-commit<=2.1.1 * upgrade pip; remove old clang-format; remove redundant apt update * remove redundant apt-get update * remove duplicate apt-get update that will cause cinn download fail * remove duplicate pip upgrade * add --fix-missing to avoid cinn docker build fail * remove duplicate apt-get update in make_cinn_docker * make cinn command in the end * solve gpg problem * remove unneccessary modification
zhhsplendid
added a commit
that referenced
this pull request
Jun 27, 2022
The paddle-cinn failed recently and block all PRs from merging. We found the key error reason from the log:  The CI environment didn't contain llvm. We then debug and found #43534 deleted the llvm due to clang-format upgrade:  So this PR added the llvm back. However, `clang-llvm-3.8.0` contains `clang-format-3.8`, so we modified the old command `cp -r` to `cp -rn`, which could ignore the installed `clang-format-13`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe