Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix paddle.vision.models.* en #43636

Merged
merged 18 commits into from Jun 23, 2022

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Jun 17, 2022

PR types

Others

PR changes

Docs

Describe

PaddlePaddle/docs#4936 的英文文档修复 PR

@paddle-bot-old paddle-bot-old bot added contributor External developers status: proposed labels Jun 17, 2022
@paddle-bot-old
Copy link

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@SigureMo SigureMo changed the title [WIP, Don't review] fix paddle.vision.models.* en docs, test=document_fix fix paddle.vision.models.* en docs, test=document_fix Jun 17, 2022
@SigureMo SigureMo marked this pull request as ready for review June 17, 2022 14:44
@SigureMo SigureMo changed the title fix paddle.vision.models.* en docs, test=document_fix fix paddle.vision.models.* en docs Jun 17, 2022
python/paddle/vision/models/densenet.py Outdated Show resolved Hide resolved
python/paddle/vision/models/mobilenetv2.py Outdated Show resolved Hide resolved
@@ -181,11 +184,17 @@ def _mobilenet(arch, pretrained=False, **kwargs):


def mobilenet_v2(pretrained=False, scale=1.0, **kwargs):
"""MobileNetV2
"""MobileNetV2 from
`"MobileNetV2: Inverted Residuals and Linear Bottlenecks" <https://arxiv.org/abs/1801.04381>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英文中使用"有些奇怪
image

@BrilliantYuKaimin 有什么规范建议吗?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以直接去掉引号,因为从超链接已经可以看出这部分是一个整体。或者使用斜体,以起到汉语里书名号的作用。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个我再调研一下吧,看看如何规范的引用文章

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

仅仅只是一个参考,目前 torchvision 里的论文链接也是这样子的

image

不过还是希望能有一个「论文/文章引用」的规范细则来规范文档中所有引用的格式~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯嗯,规范的事情晚上PFCC会上讨论,确实是需要一个细则,可以先看看这个issue:#43656

Copy link
Contributor

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!
LGTM

@Ligoml Ligoml changed the title fix paddle.vision.models.* en docs fix paddle.vision.models.* en docs Jun 23, 2022
@Ligoml Ligoml changed the title fix paddle.vision.models.* en docs fix paddle.vision.models.* en Jun 23, 2022
@Ligoml Ligoml closed this Jun 23, 2022
@Ligoml Ligoml reopened this Jun 23, 2022
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Jun 23, 2022
@PaddlePaddle PaddlePaddle unlocked this conversation Jun 23, 2022
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Jun 23, 2022
@PaddlePaddle PaddlePaddle unlocked this conversation Jun 23, 2022
@Ligoml Ligoml merged commit fdcb57f into PaddlePaddle:develop Jun 23, 2022
@SigureMo SigureMo deleted the fix-vision-models-en-docs branch June 23, 2022 07:28
sneaxiy pushed a commit to sneaxiy/Paddle that referenced this pull request Jun 27, 2022
* add outputs for code examples, test=document_fix

* missing code example update, test=document_fix

* missing returns, test=document_fix

* fix the case of proper nouns, test=document_fix

* fix SqueezeNet code example (add a blank line), test=document_fix

* fix ShuffleNetV2 args style, test=document_fix

* missing paper links, test=document_fix

* missing `optional`, test=document_fix

* refine parameter `pretrained`, test=document_fix

* add parameter `kwargs`, test=document_fix

* refine parameter `num_classes`, test=document_fix

* capitalize the first letter, test=document_fix

* missing output of code example, test=document_fix

* fix wrong api label, test=document_fix

* refine returns, test=document_fix

* add missing `.` after paper link, test=document_fix

* remove extra `:`, test=document_fix

* :math:\`0.0\`, test=document_fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants