Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Fix en docs】 Fix document formatting*test=document_fix #43996

Merged
merged 78 commits into from Aug 8, 2022

Conversation

ReganYue
Copy link
Contributor

@ReganYue ReganYue commented Jul 1, 2022

PR types

Others

PR changes

Docs

Describe

【Fix en docs】 Fix document formatting
· Returns
· Return Type

PR of the Chinese document about this pr:PaddlePaddle/docs#4978

  • paddle.static.save_inference_model不需要修改。
  • roi_perspective_transform已进行修改。
  • paddle.static.data 中文文档不需要修改
  • py_reader 没有在Web文档找到此API,但是找到了对应的文档文件,进行了修改。
  • paddle.nn.functional.square_error_cost中文文档没有此问题。
  • paddle.nn.functional.mse_loss中文文档没有此问题。
  • paddle.fluid.layers.ctc_greedy_decoder 没有在Web文档找到该API,在文件中找到并进行了修改。
  • paddle.fluid.layers.im2sequence 没有在Web文档找到该API,在文件中找到并进行了修改。
  • paddle.vision.transforms.pad中文文档没有此问题。
  • paddle.fluid.layers.pad_constant_like 没有在Web文档找到该API,在文件中找到并进行了修改。
  • paddle.crop中文文档没有此问题。
  • paddle.nn.Pad2D中文文档没有此问题。
  • paddle.clip中文文档没有此问题。
  • paddle.fluid.layers.space_to_depth没有在Web文档找到该API,在文件中找到并进行了修改。
  • paddle.vision.ops.psroi_pool中文文档没有此问题。
  • paddle.nn.functional.unfold中文文档没有此问题。
  • paddle.static.nn.sequence_conv中文文档没有此问题。
  • paddle.static.nn.sequence_softmax中文文档没有此问题。
  • paddle.static.nn.sequence_pool中文文档没有此问题。
  • paddle.static.nn.sequence_concat中文文档没有此问题。
  • paddle.static.nn.sequence_first_step中文文档没有此问题。
  • paddle.static.nn.sequence_last_step中文文档没有此问题。
  • paddle.static.nn.sequence_slice中文文档没有此问题。
  • paddle.static.nn.sequence_expand中文文档没有此问题。
  • paddle.static.nn.sequence_expand_as中文文档没有此问题。
  • paddle.static.nn.sequence_pad中文文档没有此问题。
  • paddle.static.nn.sequence_enumerate中文文档没有此问题。
  • paddle.nn.functional.sequence_mask中文文档没有此问题。
  • paddle.fluid.nets.simple_img_conv_pool没有在Web文档找到该API,在文件中找到并进行了修改。
  • paddle.fluid.nets.sequence_conv_pool没有在Web文档找到该API,在文件中找到并进行了修改。
  • paddle.nn.functional.unfold中文文档没有此问题。
  • paddle.nn.functional.zeropad2d中文文档没有此问题。
  • paddle.nn.functional.cosine_similarity中文文档没有此问题。
  • paddle.nn.functional.sequence_mask中文文档没有此问题。
  • paddle.nn.functional.square_error_cost中文文档没有此问题。
  • paddle.nn.functional.smooth_l1_loss中文文档没有此问题。
  • paddle.nn.functional.margin_ranking_loss中文文档没有此问题。
  • paddle.nn.functional.mse_loss中文文档没有此问题。
  • class paddle.nn.SmoothL1Loss中文文档没有此问题。
  • paddle.clone中文文档没有此问题。
  • paddle.utils.cpp_extension.setup中文文档没有此问题。

@TCChenlong TCChenlong added the contributor External developers label Jul 4, 2022
@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 9, 2022

Sorry to inform you that e1c2b51's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@ReganYue ReganYue changed the title 【Fix en docs】 Fix document formatting 【Fix en docs】 Fix document formatting test=document_fix Jul 20, 2022
@SigureMo
Copy link
Member

emmmm,CI 里有不少 fluid API 的示例代码挂掉了,这些 fluid API 是修复任务里的吗?

@ReganYue
Copy link
Contributor Author

emmmm,CI 里有不少 fluid API 的示例代码挂掉了,这些 fluid API 是修复任务里的吗?

是我全量搜索然后进行修改的,是的,示例代码挂掉了 ^ ^

@SigureMo
Copy link
Member

我看了下,有 20 个示例代码错误,全是 fluid 的,fluid 的 API 还有必要修复吗 @Ligoml

@SigureMo
Copy link
Member

SigureMo commented Jul 23, 2022

@ReganYue 梦柳刚刚说「fluid下的API不用管」(微信上回复我的 😂),要不辛苦恢复一下?

python/paddle/nn/functional/common.py Outdated Show resolved Hide resolved
@@ -1098,7 +1094,8 @@ def margin_ranking_loss(input,
reduction (str, optional): Indicate the reduction to apply to the loss, the candicates are ``'none'``, ``'mean'``, ``'sum'``.If :attr:`reduction` is ``'none'``, the unreduced loss is returned; If :attr:`reduction` is ``'mean'``, the reduced mean loss is returned. If :attr:`reduction` is ``'sum'``, the reduced sum loss is returned. Default is ``'mean'``.
name (str, optional): Name for the operation (optional, default is None). For more information, please refer to :ref:`api_guide_Name`.

Returns: Tensor, if :attr:`reduction` is ``'mean'`` or ``'sum'``, the out shape is :math:`[1]`, otherwise the shape is the same as `input` .The same dtype as input tensor.
Returns:
Tensor, if :attr:`reduction` is ``'mean'`` or ``'sum'``, the out shape is :math:`[1]`, otherwise the shape is the same as `input` .The same dtype as input tensor.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emmm,这行有点长,最好折断下。

还有上面那个参数 reduction 那行,也太长了,非常影响阅读体验……可以参考其他几个函数折断下(目测都是一样的,可以直接 copy)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯嗯嗯

Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>
@SigureMo
Copy link
Member

image

看来偏离主线太久了,需要重新 merge 下主线了

Ligoml
Ligoml previously approved these changes Aug 3, 2022
Copy link
Contributor

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! LGTM

@ReganYue
Copy link
Contributor Author

ReganYue commented Aug 3, 2022

good job! LGTM

梦柳姐辛苦啦~

Ligoml
Ligoml previously approved these changes Aug 4, 2022
zhiqiu
zhiqiu previously approved these changes Aug 4, 2022
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ligoml Ligoml dismissed stale reviews from zhiqiu and themself via 3a04dca August 4, 2022 11:04
Ligoml
Ligoml previously approved these changes Aug 4, 2022
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ligoml Ligoml merged commit 8537eda into PaddlePaddle:develop Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants