Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Dy2Static ] convert_call support staticmethod for class. #44983

Merged
merged 16 commits into from Sep 9, 2022

Conversation

2742195759
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

convert_call support staticmethod for class.

@paddle-bot
Copy link

paddle-bot bot commented Aug 8, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

loop_vars(list|tuple): A list or tuple of variables passed to ``cond`` and ``body`` .
get_args(callable): Get all arguments that needed in true_fn and false_fn.
set_args(callable): Update arguments that modified in trure_fn and false_fn.
return_name_ids(list[string]): the returned names.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有默认值的参数是可选参数,应该备注 optional
return_name_ids(list[string]) --> return_name_ids(list[string], optional)

"Required input var should be 1-D Variable, but received {}".
format(self.shape))
return self

@static_only
def pop(self, *args):
"""
**Notes**:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note 不用加粗,格式参考 注解

Copy link
Contributor

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2742195759 2742195759 merged commit d0096ea into PaddlePaddle:develop Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants