[ Dy2static ] select input fix and while_op memory bug fixed. #45380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is convenient to convert more dynamic graph codes into static graphs.
2. add warning in while_loop risky assign
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
reviewed
Aug 24, 2022
| @@ -1190,6 +1190,13 @@ def assign_skip_lod_tensor_array(input, output): | |||
| """ | |||
| Assign input to output, but skip the process of copying LoDTensorArray unless it's created in while_block. | |||
| """ | |||
|
|
|||
| def _shape_diff(vara, varb): | |||
There was a problem hiding this comment.
Suggested change
| def _shape_diff(vara, varb): | |
| def has_shape_diff(x, y): |
|
|
||
| def _shape_diff(vara, varb): | ||
| if len(vara.shape) != len(varb.shape): return True | ||
| for sa, sb in zip(vara.shape, varb.shape): |
There was a problem hiding this comment.
Suggested change
| for sa, sb in zip(vara.shape, varb.shape): | |
| for a, b in zip(x.shape, y.shape): |
1. a bug in while_op no_need_copy_var, which causes gpu memory leakage 2. a bug in undefined_var where the stop_gradient should be False.
2742195759
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
select input fix + while_loop risky assign warning