Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate squeeze to phi, test=kunlun #45851

Closed
wants to merge 1 commit into from

Conversation

ykkk2333
Copy link
Contributor

@ykkk2333 ykkk2333 commented Sep 7, 2022

PR types

Others

PR changes

OPs

Describe

migrate squeeze to phi and fix gaussian random xpu place bug

@paddle-bot
Copy link

paddle-bot bot commented Sep 7, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

YuanRisheng
YuanRisheng previously approved these changes Sep 8, 2022
Copy link
Contributor

@YuanRisheng YuanRisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个pr可以先合入,不过和之前迁移的unsqueeze一样,squeeze当时迁移的不够规范,辛苦下个pr参考unsqueeze的方式,将cpu/gpu/xpu的代码放到kernels根目录的一个文件中吧

@ykkk2333 ykkk2333 closed this Sep 8, 2022
@ykkk2333 ykkk2333 reopened this Sep 8, 2022
@ykkk2333
Copy link
Contributor Author

ykkk2333 commented Sep 8, 2022

这个pr可以先合入,不过和之前迁移的unsqueeze一样,squeeze当时迁移的不够规范,辛苦下个pr参考unsqueeze的方式,将cpu/gpu/xpu的代码放到kernels根目录的一个文件中吧

好的,下个pr会修改,请先帮忙合入下,谢谢~

houj04
houj04 previously approved these changes Sep 8, 2022
chenwhql
chenwhql previously approved these changes Sep 9, 2022
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZzSean
ZzSean previously approved these changes Sep 9, 2022
Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for CI-OP-Benchmark

@paddle-bot
Copy link

paddle-bot bot commented Oct 26, 2022

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨原生算子开发规范,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants