-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
代码退场,清除了与python2相关的一些条件分支 #46696
代码退场,清除了与python2相关的一些条件分支 #46696
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
✅ This PR's description meets the template requirements! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有一些小建议(๑><๑),此外貌似还有两个文件没有修改
Paddle/python/paddle/tests/test_callback_visualdl.py
Lines 51 to 52 in dc3b938
if sys.version_info < (3, ): | |
return |
Paddle/python/paddle/fluid/param_attr.py
Lines 87 to 90 in dc3b938
if sys.version_info.major == 2: | |
check_type(name, "name", (str, type(None), unicode), "ParamAttr") | |
else: | |
check_type(name, "name", (str, type(None)), "ParamAttr") |
else: | ||
check_type(shapes, 'shapes', integer_types, 'RNNCell') | ||
check_type(shapes, 'shapes', int, 'RNNCell') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已经豁免
PR types
Others
PR changes
Others
Describe
来源自 Call for contribution - Python 2.7 相关代码退场
代码退场,清除了 rnn layer, unittests, pslib 等代码中一些 python2 相关的条件分支