Update design doc for Python Layer #4698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquesqiao
reviewed
Oct 11, 2017
doc/design/python_api.md
Outdated
|
|
||
| 1. The layer developer can figure out how many common functions they can use by just typing `self.` in an IDE. | ||
| 2. It is easy to understand and develop since inheritance is a common way to reuse code. | ||
| 3. It is transparent for end-users since we can wrap a functor class to a function. |
There was a problem hiding this comment.
maybe Add a Conclusion part that we choose Functor to build our layer.
jacquesqiao
reviewed
Oct 11, 2017
doc/design/python_api.md
Outdated
| self.kwargs = kwargs | ||
|
|
||
| def __call__(self): | ||
| raise NotImplementedError("LayerBase is a ") |
There was a problem hiding this comment.
complete the msg of LayerBase is a
jacquesqiao
reviewed
Oct 11, 2017
doc/design/python_api.md
Outdated
| We can provide a decorator to wrap a functor class as a function. The code is as follows. | ||
|
|
||
| ```python | ||
| def export(name): |
There was a problem hiding this comment.
maybe export_layer or layer? make user be sure what this decorator is used for.
…le into feature/update_layer_design
reyoung
force-pushed
the
feature/update_layer_design
branch
from
03c6c98
to
7f87c49
Compare
emailweixu
reviewed
Oct 17, 2017
| We not only use the fewer lines of code to write `fc_layer` but also make the code clearer to understand. At the same time, layer developers can figure out what function they can invoke by typing `helper.` in a python editor. | ||
|
|
||
|
|
||
| ### Implementation of layer helper | ||
|
|
There was a problem hiding this comment.
Will the new api be compatible with v2 api?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is about how to implement layer function. The logic in this PR is as follow:
FullyConnectedlayer if we do not provide any common functions. So it is necessary to give a mechanism for code reusing.