expose AppendBackward of ProgramDesc to python #4699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
previously approved these changes
Oct 11, 2017
paddle/framework/backward.h
Outdated
| @@ -27,6 +27,8 @@ extern std::unique_ptr<OperatorBase> Backward( | |||
| const OperatorBase& forwardOp, | |||
| const std::unordered_set<std::string>& no_grad_vars); | |||
|
|
|||
| // TODO(someone): Add target as parameter and generate backward op | |||
There was a problem hiding this comment.
Let's assign this TODO to some specific person when we create it.
23 tasks
JiayiFeng
reviewed
Oct 11, 2017
paddle/pybind/protobuf.cc
Outdated
| @@ -116,6 +117,11 @@ void BindProgramDesc(py::module &m) { | |||
| py::return_value_policy::reference) | |||
| .def("append_block", &ProgramDescBind::AppendBlock, | |||
| py::return_value_policy::reference) | |||
| .def("backward", | |||
There was a problem hiding this comment.
I think append_backward is a better name. backward means the process that executes gradient op one by one, not append them.
|
|
||
| self.assertEqual(len(block.all_ops()), 1) | ||
| prog.backward(set()) | ||
| self.assertEqual(len(block.all_ops()), 3) |
There was a problem hiding this comment.
Add more check here to make sure additional ops are exactly what we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project: #4679
fix: #4694