make all cpp tests dynamic linked to libpaddle.so [except windows] #47088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhiqiu
force-pushed
the
dev/cpp_test_dynamic_link
branch
10 times, most recently
from
da6752b
to
3254dfd
Compare
zhiqiu
changed the title
zhiqiu
force-pushed
the
dev/cpp_test_dynamic_link
branch
3 times, most recently
from
14be5aa
to
b087c30
Compare
zhiqiu
force-pushed
the
dev/cpp_test_dynamic_link
branch
from
b087c30
to
7006947
Compare
zhiqiu
added a commit
to zhiqiu/Paddle
that referenced
this pull request
Nov 3, 2022
…addlePaddle#47088) * make all cpp tests dynamic linked to libpaddle.so * add comments * keep old cc_test for some tests * fix some ut * make some ut use cc_test_old * fix typos and fit for win32 * fix lib path * fix some tests * skip lite test * fit for rocm * fit for cinn * fit for mac * fit for win32 * skip inference ut * skip windows * fix coverage
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
make all cpp tests dynamic linked to libpaddle.so
see the comments added in
paddle/CMakeLists.txtfor detailsWhy
libpaddle.soprovidedResult
The build directory of coverage CI decreased from 168G to 117G, 51G reduced, 30%.
PS0. There are 229 tests using dynamic link now and still some cpp tests use static link, configured using
cc_test_oldinCMakeLists.txt.PS1. The dynamic library on windows encountered
unresolved symbolproblem, so it is not supported now.PS2. Found some tests contains symbols that is not in
libpaddle.so, it means that the code is unused. So here are some PRs to clean the related code.#47103