Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine conv2d naive function #4742

Merged
merged 6 commits into from
Oct 12, 2017
Merged

refine conv2d naive function #4742

merged 6 commits into from
Oct 12, 2017

Conversation

chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Oct 12, 2017 •
edited

fix #4750

hedaoyuan
hedaoyuan reviewed Oct 12, 2017
View reviewed changes
python/paddle/v2/framework/tests/test_conv2d_op.py Outdated
@@ -91,30 +76,47 @@ def test_check_grad_no_input(self):
max_relative_error=0.05,
no_grad_set=set(['Input']))

def init_groups(self):
def init_test_case(self):
self.groups = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

init_group will be covered by this code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@chengduoZH chengduoZH merged commit 487a13b into PaddlePaddle:develop Oct 12, 2017
@chengduoZH chengduoZH deleted the refine_conv2_naive_func branch October 12, 2017 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedaoyuan hedaoyuan hedaoyuan approved these changes

@typhoonzero typhoonzero Awaiting requested review from typhoonzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

finetune conv2d naive function
2 participants
@chengduoZH @hedaoyuan