Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove functions not belong to public-api from __all__ #47502

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

zoooo0820
Copy link
Contributor

@zoooo0820 zoooo0820 commented Oct 31, 2022

PR types

Bug fixes

PR changes

APIs

Describe

From version 2.0,the public APIs will be add to __all__ in each module. So the definition of public api in Paddle is the Class / function in __all__ (exclude modules belongs to fluid), and each of them should be maintained continuously. However, there are some unexpected functions are wrongly regarded as public apis, which we do not recommend to use them by the path. This PR is to remove them.

Note: the definition of these functions are not be removed, so the developers can still use these functions.

The following will be removed from the public api:

paddle.tensor.ops.*    (should be used by paddle.xxx or paddle.Tensor.xxx)
paddle.audio.datasets,esc50.ESC50 (there is already paddle.audio.datasets.ESC50)
paddle.audio.datasets,tess.TESS (there is already paddle.audio.datasets.TESS)
paddle.distributed.commuication.stream (stream.py is a module, only callable function or Class can be API)
paddle.geometric.message_passing.* (should be used by paddle.geometric.xxx)
paddle.geometric.sampling.* (should be used by paddle.geometric.xxx)
paddle.incubate.multiprocessing.* (muiltiprocessing is a other python packages, not a function provided by Paddle)

@paddle-bot
Copy link

paddle-bot bot commented Oct 31, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@SmileGoat SmileGoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,paddle audio

Copy link
Contributor

@DesmonDay DesmonDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff41404 jeff41404 merged commit 698128d into PaddlePaddle:develop Nov 2, 2022
@zoooo0820 zoooo0820 deleted the clean_public_apis branch November 3, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants