Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VarDesc from design doc #4769

Merged
merged 4 commits into from
Oct 13, 2017
Merged

Update VarDesc from design doc #4769

merged 4 commits into from
Oct 13, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Oct 12, 2017

No description provided.

jacquesqiao
jacquesqiao previously approved these changes Oct 12, 2017
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jacquesqiao
jacquesqiao approved these changes Oct 13, 2017
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@reyoung reyoung merged commit d17eb73 into PaddlePaddle:develop Oct 13, 2017
@reyoung reyoung deleted the feature/change_vardesc_proto branch October 28, 2017 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacquesqiao jacquesqiao jacquesqiao approved these changes

@JiayiFeng JiayiFeng Awaiting requested review from JiayiFeng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reyoung @jacquesqiao