Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHI]Standardise some C++ API (Part4) #47702

Merged
merged 7 commits into from Nov 10, 2022

Conversation

YuanRisheng
Copy link
Contributor

@YuanRisheng YuanRisheng commented Nov 7, 2022

PR types

Others

PR changes

Others

Describe

标准化equal/fmax/fmin/greater equal/greater than/less equal/less than/not equal/relu6/swish/hardswish c++ api,去除c++ api的默认参数
后续还会继续对接口标准化,此PR是系列工作的第四个PR

异构设备相关修改:PaddlePaddle/PaddleCustomDevice#186

@paddle-bot
Copy link

paddle-bot bot commented Nov 7, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Nov 7, 2022
@PaddlePaddle PaddlePaddle unlocked this conversation Nov 7, 2022
jiahy0825
jiahy0825 previously approved these changes Nov 9, 2022
zyfncg
zyfncg previously approved these changes Nov 9, 2022
@@ -0,0 +1,99 @@
// Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

开头多了个空格

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@YuanRisheng YuanRisheng dismissed stale reviews from zyfncg and jiahy0825 via 567a0c3 November 9, 2022 08:24
Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for CI-OP-Benchmark

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants