Adding Hard Sigmoid Activation #4771
Conversation
| This is much faster than sigmoid. | ||
|
|
||
| hard_sigmoid = max(0, min(1, slope * x + shift)) | ||
|
|
| framework::OpAttrChecker *op_checker) | ||
| : OpProtoAndCheckerMaker(proto, op_checker) { | ||
| AddInput("X", "Input of HardSigmoid operator"); | ||
| AddOutput("Y", "Output of HardSigmoid operator"); |
There was a problem hiding this comment.
Out name convention documentation suggest us use the "(type, default value) usage" style to write the comments. I guess this comment can be further refined. And fc_op is a good example: https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/operators/fc_op.cc#L122.
There was a problem hiding this comment.
@lcy-seso Do you recommend that I modify this for all ops in the activation.cc? Unfortunately all activations in this file do not follow the naming convention. The other option is that I merge this PR and open an issue to fix the naming convention of all Ops in Activations? The second option will keep this PR clean. What do you suggest?
There was a problem hiding this comment.
I prefer we guarantee all the newly written unmerged PR follows this naming convention first, and make a new PR later to fix all the old codes.
There was a problem hiding this comment.
Thank you for pointing this out. Opened a separate issue to fix this. #4772
Fixes #4605