Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add selected rows #4782

Merged
merged 4 commits into from
Oct 13, 2017
Merged

add selected rows #4782

merged 4 commits into from
Oct 13, 2017

Conversation

QiJune
Copy link
Member

@QiJune QiJune commented Oct 13, 2017 •
edited

Fix #4783

reyoung
reyoung reviewed Oct 13, 2017
View reviewed changes
paddle/framework/selected_rows.h Outdated
value_.reset(new Tensor());
}

SelectedRows() {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add a dector?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have unique_ptr<Tensor>, we do not need a dector.

reyoung
reyoung reviewed Oct 13, 2017
View reviewed changes
paddle/framework/selected_rows.h Outdated

platform::Place place() const { return value_->place(); }

Tensor& value() const { return *value_; }
Copy link
Collaborator

@reyoung reyoung Oct 13, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const Tensor& value() const {...}
Tensor* mutable_value() {}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

reyoung
reyoung approved these changes Oct 13, 2017
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@QiJune QiJune merged commit 9165235 into PaddlePaddle:develop Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyoung reyoung reyoung approved these changes

@jacquesqiao jacquesqiao Awaiting requested review from jacquesqiao

Assignees
No one assigned
Labels
None yet
Projects
PaddlePaddle Refactoring: Phase 3
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@QiJune @reyoung