-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grad_name_map to record correspondences between vars and grad_vars #4794
Add grad_name_map to record correspondences between vars and grad_vars #4794
Conversation
paddle/framework/backward.cc
Outdated
const OperatorBase& op, | ||
const std::unordered_set<std::string>& no_grad_set) { | ||
const OperatorBase& op, const std::unordered_set<std::string>& no_grad_set, | ||
std::unordered_map<std::string, std::string>* grad_name_map) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe grad_name_map
==> grad_to_var
? or some better name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we do not need change runtime implementation. But, just leave it there is OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extraordinary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
No description provided.