create grad_var when run Backward pass #4796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… improve-backward
… improve-backward
… improve-backward
reyoung
reviewed
Oct 13, 2017
paddle/framework/backward.cc
Outdated
| @@ -375,10 +376,18 @@ std::vector<std::unique_ptr<OpDescBind>> MakeBlockBackward( | |||
| backward_descs.insert(backward_descs.begin() + p.first + 1, | |||
| std::move(p.second)); | |||
| } | |||
|
|
|||
| // insert fill one op for target | |||
| std::unique_ptr<OpDescBind> fill_one_op(new OpDescBind( | |||
There was a problem hiding this comment.
It should be in AppendBackward. That logic is wrong.
reyoung
reviewed
Oct 13, 2017
paddle/framework/backward.cc
Outdated
| auto backward_op_descs = | ||
| MakeBlockBackward(program_desc, root_block_idx, no_grad_var_names); | ||
| auto& forw_op_descs = program_desc.Block(root_block_idx)->ops_; | ||
| auto backward_op_descs = MakeBlockBackward(program_desc, root_block_idx, |
There was a problem hiding this comment.
target does not need to pass to MakeBlockBackward.
reyoung
reviewed
Oct 13, 2017
paddle/framework/backward.cc
Outdated
| auto backward_op_descs = MakeBlockBackward(program_desc, root_block_idx, | ||
| target, no_grad_var_names); | ||
| auto root_block = program_desc.Block(root_block_idx); | ||
| auto& forward_op_descs = root_block->ops_; |
reyoung
reviewed
Oct 13, 2017
paddle/framework/backward.cc
Outdated
| for (size_t index = backward_start_index; index < forward_op_descs.size(); | ||
| ++index) { | ||
| auto& op = forward_op_descs.at(index); | ||
| for (auto& input : op->Inputs()) { |
There was a problem hiding this comment.
Input does not need to be created
reyoung
reviewed
Oct 13, 2017
paddle/framework/backward.cc
Outdated
| auto& forw_op_descs = program_desc.Block(root_block_idx)->ops_; | ||
| auto backward_op_descs = MakeBlockBackward(program_desc, root_block_idx, | ||
| target, no_grad_var_names); | ||
| auto root_block = program_desc.Block(root_block_idx); |
There was a problem hiding this comment.
Not only root_block need create vars.
23 tasks
reyoung
reviewed
Oct 14, 2017
paddle/framework/backward.cc
Outdated
| root_block->NewVar(fill_one_op_out); | ||
|
|
||
| // create grad_var for all blocks in this program | ||
| for (size_t block_index = 0; block_index < program_desc.Size(); |
There was a problem hiding this comment.
Not all block is generated by backward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project: #4679
fix: #4767