add some basic math functor for SelectedRows #4801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
reviewed
Oct 13, 2017
| template struct SetConstant<platform::CPUPlace, float>; | ||
|
|
||
| namespace detail { | ||
| size_t FindPos(const std::vector<int64_t>& rows, int64_t value) { |
There was a problem hiding this comment.
return std::find(rows.begin(), rows.end(), value) - rows.begin();
QiJune
changed the title
QiJune
force-pushed
the
add_selected_rows_functor
branch
from
df2d176
to
89758ad
Compare
…/Paddle into add_selected_rows_functor
wangkuiyi
requested changes
Oct 16, 2017
| @@ -130,6 +132,99 @@ void matmul<platform::CPUPlace, double>( | |||
| matrix_b.data<double>(), beta, matrix_out->data<double>()); | |||
| } | |||
|
|
|||
| template struct SetConstant<platform::CPUPlace, float>; | |||
There was a problem hiding this comment.
Let us move the added code into paddle/operators/math/selected_rows.{h,cc,cu}.
QiJune
force-pushed
the
add_selected_rows_functor
branch
3 times, most recently
from
50f53b5
to
eb43f22
Compare
QiJune
force-pushed
the
add_selected_rows_functor
branch
from
eb43f22
to
ab5dc9f
Compare
QiJune
force-pushed
the
add_selected_rows_functor
branch
from
f6655d9
to
0d7b1fd
Compare
typhoonzero
reviewed
Oct 16, 2017
|
|
||
| auto* out_data = out_value->data<T>(); | ||
| auto* in1_data = in1_value.data<T>(); | ||
| memory::Copy(boost::get<platform::CPUPlace>(out_place), out_data, |
There was a problem hiding this comment.
I'm not sure, if we have duplicated rows selected, the row value is copied multiple times?
There was a problem hiding this comment.
Yes, the row value will be just simply concated.
// concat rows
out_rows.insert(out_rows.end(), in1_rows.begin(), in1_rows.end());
out_rows.insert(out_rows.end(), in2_rows.begin(), in2_rows.end());
output->set_rows(out_rows);
wangkuiyi
approved these changes
Oct 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.