Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Name convention of operator attributes #4807

Merged
merged 3 commits into from
Oct 16, 2017
Merged

Change Name convention of operator attributes #4807

merged 3 commits into from
Oct 16, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Oct 15, 2017

Follow PEP8

@QiJune
Copy link
Member

QiJune commented Oct 15, 2017

Please refer to https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/operators/name_convention.md.

Attribute name follows the camelCase

Maybe we have to unify the name convention.

wangkuiyi
wangkuiyi previously approved these changes Oct 16, 2017
View reviewed changes
@wangkuiyi
Copy link
Collaborator

Sorry that I approved by mistake -- I read @QiJune 's comment after the approval. Please follow @QiJune 's comment instead of mine.

@reyoung reyoung changed the title Change dataType to data_type Change Name convention of operator attributes Oct 16, 2017
QiJune
QiJune approved these changes Oct 16, 2017
View reviewed changes
Copy link
Member

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyoung reyoung merged commit 75d0c79 into PaddlePaddle:develop Oct 16, 2017
@reyoung reyoung deleted the feature/unify_data_type branch October 28, 2017 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QiJune QiJune QiJune approved these changes

@wangkuiyi wangkuiyi wangkuiyi left review comments

@jacquesqiao jacquesqiao Awaiting requested review from jacquesqiao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reyoung @QiJune @wangkuiyi