Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite feed/fetch op #4815

Merged
merged 1 commit into from
Oct 16, 2017
Merged

Rewrite feed/fetch op #4815

merged 1 commit into from
Oct 16, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Oct 15, 2017 •
edited by wangkuiyi

Fixes #4819

@reyoung
Rewrite feed/fetch op
037c5e5 
* Feed/Fetch op just plain operator, not a OpWithKernel
* Do not register OpInfoMaker since Feed/Fetch will never be
  configured by users
* Feed/Fetch op has empty gradient
* Feed/Fetch op do not hard code `feed_variable`, `fetch_variable` as
  its input and output, make it as a plain Operator input/output
@reyoung reyoung merged commit 4df6cf4 into PaddlePaddle:develop Oct 16, 2017
@tonyyang-svail tonyyang-svail mentioned this pull request Oct 18, 2017
Closed
@reyoung reyoung deleted the feature/new_feed_fetch_op branch October 28, 2017 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangkuiyi wangkuiyi wangkuiyi approved these changes

@QiJune QiJune Awaiting requested review from QiJune

@JiayiFeng JiayiFeng Awaiting requested review from JiayiFeng

@tonyyang-svail tonyyang-svail Awaiting requested review from tonyyang-svail

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reyoung @wangkuiyi